Skip to content

fix: tx-link decode #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

fix: tx-link decode #762

merged 2 commits into from
Aug 19, 2025

Conversation

@tfrg
Copy link
Contributor

@tfrg tfrg commented Aug 19, 2025 •
edited
Loading

What type of PR is this?

  • bug

What this PR does:

  • Apply decodeURIComponent to all transaction arguments to correctly decode URL-encoded values
  • Add tests for different URL encoding cases

Issue

@tfrg tfrg requested a review from a team as a code owner August 19, 2025 11:48
jinoosss
jinoosss approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@jinoosss jinoosss merged commit b029c84 into main Aug 19, 2025
2 checks passed
@jinoosss jinoosss deleted the ADN-723-tx-link-decode branch August 19, 2025 11:57
@jinoosss jinoosss mentioned this pull request Aug 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinoosss jinoosss jinoosss approved these changes

@jinseon-92 jinseon-92 Awaiting requested review from jinseon-92 jinseon-92 is a code owner automatically assigned from onbloc/core-engineers

@dongwon8247 dongwon8247 Awaiting requested review from dongwon8247 dongwon8247 is a code owner automatically assigned from onbloc/core-engineers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tfrg @jinoosss