Skip to content

Conversation

@jinoosss
Copy link
Member

What type of PR is this?

  • feature

What this PR does:

This PR implements comprehensive support for storage deposits in the Adena wallet, including calculation, parsing, and user interface display. Storage deposits are an important aspect of Gno blockchain transactions that users need to understand and track.

Key Features

1. Storage Deposit Parsing Infrastructure

  • New types and enums: Added StorageDepositEventType and StorageDepositAttributeKey to handle storage deposit events
  • Event parsing: Implemented parseStorageDeposits() function to extract storage deposit information from transaction events
  • Storage usage calculation: Added utility to parse storage usage strings and calculate deposit amounts

2. Storage Deposit UI Component

  • New StorageDeposit component: Created a dedicated component to display storage deposit amounts with proper formatting
  • Visual indicators: Uses different colors to distinguish between deposits (neutral) and refunds (green)
  • Tooltip support: Added help tooltip explaining what storage deposits are and how they work
  • Loading and error states: Proper handling of loading states and error messages

3. Transaction Approval Integration

  • Gas estimation updates: Modified gas price tier estimation to include storage deposit calculations
  • UI integration: Added storage deposit display alongside network fees in transaction approval screens
  • Error handling: Integrated storage deposit errors with existing transaction error handling

4. Transaction History Enhancement

  • History display: Added storage deposit information to transaction history items
  • Sign indicators: Shows positive/negative amounts with appropriate visual indicators
  • Detail view: Enhanced transaction detail pages to display storage deposit information

5. User Experience Improvements

  • Informational tooltips: Added contextual help for users to understand storage deposits and related fields
  • Consistent formatting: Unified number formatting with sign indicators for positive/negative amounts
  • Responsive design: Proper tooltip positioning that adapts to screen boundaries

@jinoosss jinoosss requested a review from a team as a code owner August 22, 2025 11:06
@jinoosss jinoosss merged commit 17cdb5d into main Aug 22, 2025
2 checks passed
@jinoosss jinoosss deleted the ADN-729-adena-storage-deposit-updates branch August 22, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants