fix: bug: Automatic publicPath is not supported in this browser - #811
Draft
SillyZir wants to merge 1 commit into
Draft
fix: bug: Automatic publicPath is not supported in this browser#811SillyZir wants to merge 1 commit into
SillyZir wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set an explicit
publicPathin the webpack output configuration to prevent the "Automatic publicPath is not supported in this browser" error that crashes the Adena extension on simple web pages.Fixes #783
Problem
When visiting pages with minimal JavaScript (e.g., no
<script src>tags or simple sites like example.com), webpack's runtime could not automatically determine thepublicPathfromdocument.currentScript, causing the extension to crash withUncaught Error: Automatic publicPath is not supported in this browser.Solution
Added an explicit
publicPathproperty to theoutputconfiguration inpackages/adena-extension/webpack.config.js, removing the reliance on webpack's automatic public path detection. The manifest generation was also cleaned up to directly referencepackageInfo.descriptionandpackageInfo.versioninstead of spreading parsed content, improving clarity.Impact
The Adena extension will no longer crash on pages with minimal or no script tags, restoring functionality across Chrome, Brave, and Edge on all websites regardless of their JavaScript usage.