fix(bill-progress): hint e LOG — commenti Copilot post-merge #57#58
Merged
Conversation
…all'escaper reale Commenti Copilot post-merge su PR #57: - l'hint Camera non cita più "date" (parametro inesistente): nomina i filtri reali (keyword, intervallo di date) e la paginazione (limit/offset) - LOG.md aggiornato: l'escape SPARQL usa un helper dedicato, non JSON.stringify Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
| Filename | Overview |
|---|---|
| src/tools/bill-progress.ts | Updates only the Camera empty-result hint text, with no change to query construction or result handling. |
| LOG.md | Aligns the changelog wording with the current hint text and SPARQL literal escaping implementation. |
Reviews (1): Last reviewed commit: "fix(bill-progress): hint senza parametro..." | Re-trigger Greptile
There was a problem hiding this comment.
Pull request overview
Aggiorna testi non-funzionali a seguito di commenti Copilot arrivati dopo il merge di #57, mantenendo invariato il comportamento del tool bill-progress e allineando il changelog all’implementazione attuale.
Changes:
- Raffinato l’
emptyHintdel ramo Camera inbill-progressrendendolo coerente con i parametri reali (keyword, intervallo date,limit/offset) e neutro rispetto all’entrypoint. - Corretto
LOG.mdper riflettere l’escape dei literal SPARQL tramite helper dedicato (nonJSON.stringify) e dettagliato il tie-breaker inORDER BY.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/bill-progress.ts | Aggiorna il testo dell’hint “Camera vuoto” per menzionare filtri/paginazione reali senza cambiare la logica. |
| LOG.md | Allinea la voce di changelog a quanto effettivamente implementato (helper di escape e nota su ORDER BY). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segue i due commenti Copilot arrivati dopo il merge di #57 (l'auto-merge è partito prima che la re-review atterrasse).
datecome parametro (lo schema esponedateFrom/dateTo). Ora nomina i filtri reali (keyword, intervallo di date) e la paginazione (limit/offset), testo neutro rispetto all'entrypoint.JSON.stringify, ma è stato introdotto un helper dedicato che lo sconsiglia. Voce allineata all'implementazione reale.Nessun cambio di comportamento delle query; solo testo dell'hint e changelog.