Skip to content

Conversation

@joellidin
Copy link
Collaborator

@joellidin joellidin commented Nov 4, 2025

  • (hparams) Update bootstrap window
  • Bump run version

Description

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Feature (adding new functionality)
  • Fix (resolving a bug or issue)
  • Docs (documentation updates)
  • Refactor (code changes that don't affect functionality)
  • Maintenance (dependency updates or other maintenance)
  • Tests (adding or improving tests)
  • Breaking change (fix or feature with incompatible API changes)
  • Other: _____

Branch Naming

  • My branch follows the project's naming convention (e.g., feature/add-new-capability)

Commit Messages

  • My commits are small, atomic, and have proper commit messages
  • Commit messages are in imperative mood with a capitalized summary under 50 chars

Code Quality

  • I've performed a self-review of my code
  • I've added appropriate docstrings following the project's conventions
  • I've added proper logging where necessary (without trailing periods)
  • I've applied linting and formatting with Ruff
  • My code generates no new warnings

Testing

  • I've added tests for new functionality or bug fixes
  • All tests pass locally with my changes
  • Test coverage has not decreased

Documentation

  • I've updated documentation to reflect my changes
  • I've updated comments in hard-to-understand areas

If this is a breaking change

Screenshots/Examples

Additional Notes

Summary by CodeRabbit

Release Notes

  • Version

    • Updated to version 2.1.14
  • Model Updates

    • Adjusted hyperparameter configurations

- Set outer_learning_rate to 0.5
- Bump checkpoint_init_window to 59147
- Increment flatten_start_step to 2740
@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updated three hyperparameter values in hparams/hparams.json (outer_learning_rate, checkpoint_init_window, flatten_start_step) and bumped the module version from 2.1.13 to 2.1.14 in src/tplr/__init__.py.

Changes

Cohort / File(s) Summary
Hyperparameter Updates
hparams/hparams.json
Updated outer_learning_rate from 0.6 to 0.5, checkpoint_init_window from 59057 to 59147, and flatten_start_step in optimizer scheduler from 2650 to 2740
Version Bump
src/tplr/__init__.py
Incremented __version__ from 2.1.13 to 2.1.14

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Changes are limited to configuration value adjustments and a straightforward version bump
  • No logic modifications, error handling changes, or structural edits

Possibly related PRs

Poem

🐰 A nibble here, a tweak right there,
Version bumps dance through the air,
Parameters polished, learning rates refined,
2.1.14 awaits, perfectly aligned! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb311a8 and dab2d4d.

📒 Files selected for processing (2)
  • hparams/hparams.json (3 hunks)
  • src/tplr/__init__.py (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joellidin joellidin merged commit 080905b into main Nov 4, 2025
5 of 6 checks passed
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   57.91%   57.91%           
=======================================
  Files          27       27           
  Lines        4890     4890           
=======================================
  Hits         2832     2832           
  Misses       2058     2058           
Files with missing lines Coverage Δ
src/tplr/__init__.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants