Created a POM for this project so it can be built by maven#3
Open
liftyourgame wants to merge 16 commits intoone2team:masterfrom
Open
Created a POM for this project so it can be built by maven#3liftyourgame wants to merge 16 commits intoone2team:masterfrom
liftyourgame wants to merge 16 commits intoone2team:masterfrom
Conversation
Moved js resources to under src/main/resources
…that it uses the modern rhino. Some charts are still not rendering correctly.
|
Any answer for this pull request? |
|
Charts produced by this PR do not look good: 1- PR change lots of files that are not maven. has not been upgraded. |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I created a pom.xml file so that this library can built by maven and then uploaded to the central maven repository. My version also deletes the libs folder as these jars could be downloaded automatically by maven.
Regards,
Greg