Add fast path for teardown check with a shared thread #321
+149
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
force-pushed
the
l0_teardown_shared_thread
branch
3 times, most recently
from
38b34cf to
64d2e4c
Compare
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
…ceptions in the thread Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
l0_teardown_shared_thread
branch
from
2742c4f to
485c23b
Compare
rwmcguir
reviewed
Apr 22, 2025
source/lib/ze_lib.cpp
Outdated
| @@ -1,3 +1,4 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
White space promotes readership?
rwmcguir
reviewed
Apr 22, 2025
source/lib/ze_lib.cpp
Outdated
| std::lock_guard<std::mutex> lock(*ze_lib::stabilityMutex); | ||
| *ze_lib::stabilityPromiseResult = std::promise<int>(); | ||
| *ze_lib::resultFutureResult = ze_lib::stabilityPromiseResult->get_future(); | ||
| ze_lib::stabilityCheckThreadStarted->store(1); |
Contributor
There was a problem hiding this comment.
Slight comment for readability, you are using 1 here (likely to indicate RUNNING) and back in the destruction you use -1 as a message to exit the thread. Maybe use define or enums so we can read it easier. :-)
1 = RUNNING
0 = STOPPED? QUISECED?
-1 = EXIT_THREAD?
rwmcguir
reviewed
Apr 22, 2025
Contributor
rwmcguir
left a comment
rwmcguir
left a comment
There was a problem hiding this comment.
Overall looks pretty good, my commentary can be approved tomorrow if we really don't want to change anything, since it is not functional.
nrspruit
force-pushed
the
l0_teardown_shared_thread
branch
2 times, most recently
from
f0f1c03 to
1b1146d
Compare
…ests Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
l0_teardown_shared_thread
branch
from
1b1146d to
c038c59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.