[AMRIBM] Multi resolution AMR (various bases & tbox) #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pected as the inputs have changed - vmins=[15,15] --> vmins=[[15,15]]
…lated to the min(snear).
antjost
requested review from
BconstantMMK,
StephaniePERON,
benoit128 and
vincentcasseau
benoit128
reviewed
Nov 7, 2025
benoit128
reviewed
Nov 7, 2025
… for the reminder.
…e here for future comits changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
Important:
This is expected and the new values 'are the good ones'
The majority of the devs. are in Generator/AMR.py and are related to the mesh generation. The changes in Connector/AMR.py are related to the use of Cmpi.trace, the inclusion of the detection and output of projection 3 and projection 4 IBM points (as is in Connector/IBM.py), and some minor things here and there.
@BconstantMMK, @StephaniePERON, @vincentcasseau, @benoit128: Given the extent of the commit, if we feel it is better to sit around a PC and discuss the approach, bug fixes, etc. I am more than open to the idea.