Use standard import placeholders #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Once I get an approval on this, I will tag a pre-release based off this branch so I can update flow-go |
3 tasks
janezpodhostnik
approved these changes
Feb 14, 2025
Collaborator
janezpodhostnik
left a comment
janezpodhostnik
left a comment
There was a problem hiding this comment.
I spot checked some files and it looks good to me, but I didn't go through everything. Please let me know if there are any files I need to specifically check.
joshuahannan
force-pushed
the
templates-replace
branch
from
613d745 to
5a4acb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all the contracts, transactions and scripts to use the standard import placeholder format
import "...."instead of the old format.I know there are a lot to review, but the changes are exactly the same for every file, so it shouldn't take too long to review
The
flow-evm bridgeis now using the core contracts templates package to replace import placeholders and uses the current format, so this needs to be updated to support that.I'll work on updating
flow-gotransaction as well.Flag: Tests are failing because
flow-gorelies on the old package that replaces addresses based on the old format. To get tests to pass, we'll need a new version of the emulator with this change.