-
Notifications
You must be signed in to change notification settings - Fork 7
Updates batch bridge transactions to also execute arbitrary calls #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: flip-318
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## flip-318 #190 +/- ##
=========================================
Coverage 81.46% 81.46%
=========================================
Files 24 24
Lines 1597 1597
=========================================
Hits 1301 1301
Misses 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@sisyphusSmiling For now I just updated the existing transaction so we don't have to copy code and to make it a little easier to illustrate to developers the ability to do many things in one atomic transaction, but if you think that it should be a separate transaction, I'm totally fine with that and can make a new one. Also how, do you feel about me making the same changes to the fungible token transaction? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you! This will work perfectly for my purposes
f03f2f7
to
ba8919a
Compare
@jribbink @sisyphusSmiling I added a transaction for fungible tokens also and made sure each transaction was new instead of modifying the existing transaction. Let me know if you need any other changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the UFix64
param value being an issue for programmatic value transfer due to the relative restriction on decimal precision. IMO the param type should be updated but might require changes to the types in the upstream hook.
Works towards onflow/fcl-js#2340 and onflow/fcl-js#2339
Description
Updates the batch bridge to EVM transaction to all take an arbitrary amount of calldata so that the caller can do any EVM calls in the same transaction.
I wanted to just update the existing transaction so that we don't have to copy code and to make it a little easier to illustrate to developers the ability to do many things in one atomic transaction.
For contributor use:
flip-318
branchFiles changed
in the Github PR explorer