Bump onflow/flow-go version with EVM Pectra hard-fork enabled#800
Conversation
m-Peter
requested review from
janezpodhostnik,
peterargue and
zhangchiqing
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| baseSize := uint64(213) | ||
| dataSize := TxMaxSize - baseSize | ||
| gasLimit := uint64(2_500_000) | ||
| gasLimit := uint64(5_500_000) |
There was a problem hiding this comment.
Change comes from: EIP-7623: Increase calldata cost.
See: https://mixbytes.io/blog/the-prague-electra-pectra-hardfork-explained#rec860520137 .
| gasPrice: conf.minGasPrice | ||
| }, 82n) | ||
| assert.equal(estimatedGas, 21358n) | ||
| assert.equal(estimatedGas, 21646n) |
There was a problem hiding this comment.
Change comes from: EIP-7623: Increase calldata cost.
See: https://mixbytes.io/blog/the-prague-electra-pectra-hardfork-explained#rec860520137 .
| { | ||
| from: conf.eoa.address.toLowerCase(), | ||
| gas: '0xb50d', | ||
| gas: '0xb56b', |
There was a problem hiding this comment.
Change comes from: EIP-7623: Increase calldata cost.
See: https://mixbytes.io/blog/the-prague-electra-pectra-hardfork-explained#rec860520137 .
| { | ||
| from: contractAddress.toLowerCase(), | ||
| gas: '0x54e1', | ||
| gas: '0x553d', |
There was a problem hiding this comment.
Change comes from: EIP-7623: Increase calldata cost.
See: https://mixbytes.io/blog/the-prague-electra-pectra-hardfork-explained#rec860520137 .
| from: conf.eoa.address.toLowerCase(), | ||
| gas: '0xcdd4', | ||
| gasUsed: '0xb38f', | ||
| gasUsed: '0xb3ed', |
There was a problem hiding this comment.
Change comes from: EIP-7623: Increase calldata cost.
See: https://mixbytes.io/blog/the-prague-electra-pectra-hardfork-explained#rec860520137 .
| from: contractAddress.toLowerCase(), | ||
| gas: '0x6d44', | ||
| gasUsed: '0x524a', | ||
| gasUsed: '0x52a8', |
There was a problem hiding this comment.
Change comes from: EIP-7623: Increase calldata cost.
See: https://mixbytes.io/blog/the-prague-electra-pectra-hardfork-explained#rec860520137 .
| '0x1' | ||
| ) | ||
| assert.equal(gasEstimate, 21510n) | ||
| assert.equal(gasEstimate, 22026n) |
There was a problem hiding this comment.
Change comes from: EIP-7623: Increase calldata cost.
See: https://mixbytes.io/blog/the-prague-electra-pectra-hardfork-explained#rec860520137 .
Kay-Zee
left a comment
Kay-Zee
left a comment
There was a problem hiding this comment.
where do the actual values come from? took a look at the link https://mixbytes.io/blog/the-prague-electra-pectra-hardfork-explained#rec860520137
is there a table / some set of calculations to arrive at these values?
@Kay-Zee That is a bit of a black box actually, and it doesn't give much value to even do so. The thing to keep in mind here is that there is an increase (even slight) when calling smart contract functions. |
m-Peter
force-pushed
the
mpeter/update-go-ethereum-v1.15.3
branch
from
c039803 to
6580d17
Compare
m-Peter
force-pushed
the
mpeter/enable-pectra-hard-fork
branch
from
2ec1d8c to
8a20740
Compare
3 participants
Work towards: onflow/flow-go#7152
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer