Skip to content

Relax log-level on processLockedKeys() for tx results #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-Peter merged 1 commit into from
Oct 10, 2025
Merged

Relax log-level on processLockedKeys() for tx results #898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions services/requester/keystore/key_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,9 @@ func (k *KeyStore) processLockedKeys(ctx context.Context) {
if k.config.COATxLookupEnabled {
txResults, err = k.client.GetTransactionResultsByBlockID(ctx, blockHeader.ID)
if err != nil && status.Code(err) != codes.Canceled {
k.logger.Error().Err(err).Msgf(
"failed to get transaction results for block ID: %s",
blockHeader.ID.Hex(),

@janezpodhostnik janezpodhostnik Oct 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we still add this? blockHeader.ID.Hex()

@m-Peter m-Peter Oct 9, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not add it, because it's already included in the error itself:

failed to get transaction results: client: rpc error: code = Internal desc =
failed to get block df6e3694dd5856d4c3c537ca2d4804aeb78fdaeb48679c506e7cd5fca2d3df95:
could not find block with ID df6e3694dd5856d4c3c537ca2d4804aeb78fdaeb48679c506e7cd5fca2d3df95

k.logger.Warn().Msgf(
"failed to get transaction results: %v",
err,
)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
continue
}
Expand Down