Update flow-go version to fix state mismatch issue - #981
Conversation
📝 WalkthroughWalkthroughChangesThe PR upgrades root and test-module dependencies, updates Web3 debug-trace expectations for additional account state fields, and disables the Dependency and trace test updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/e2e_web3js_test.go (1)
89-99: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse
t.Skip()instead of commenting out the test invocation.Commenting out the test invocation causes the
t.Runblock to execute without any assertions, silently passing. If this test is temporarily disabled, uset.Skip()to explicitly report it as skipped in the test runner output. If the test is permanently obsolete, consider removing the entiret.Runblock.♻️ Proposed refactor to skip the test properly
t.Run("deploy multicall3 contract and call methods", func(t *testing.T) { + t.Skip("Temporarily disabled: this is a pre-signed contract deployment, that only works before Amsterdam.") // set the Amsterdam hard-fork activation to 24 hours from now evmEmulator.PreviewnetAmsterdamActivation = uint64(time.Now().Add(24 * time.Hour).Unix()) defer func() { // set it back to its original value evmEmulator.PreviewnetAmsterdamActivation = uint64(0) }() - // this is a pre-signed contract deployment, that only works before - // Amsterdam. - // runWeb3Test(t, "eth_multicall3_contract_test") + runWeb3Test(t, "eth_multicall3_contract_test") })🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/e2e_web3js_test.go` around lines 89 - 99, Replace the commented-out runWeb3Test invocation inside the “deploy multicall3 contract and call methods” t.Run block with t.Skip(), so the disabled test is explicitly reported as skipped while preserving its setup and cleanup behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/e2e_web3js_test.go`:
- Around line 89-99: Replace the commented-out runWeb3Test invocation inside the
“deploy multicall3 contract and call methods” t.Run block with t.Skip(), so the
disabled test is explicitly reported as skipped while preserving its setup and
cleanup behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 305e96f4-6022-4faa-abca-532491e40043
⛔ Files ignored due to path filters (2)
go.sumis excluded by!**/*.sumtests/go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
go.modtests/e2e_web3js_test.gotests/go.modtests/web3js/debug_traces_test.js
Description
For contributor use:
masterbranchFiles changedin the Github PR explorerSummary by CodeRabbit
Bug Fixes
Tests
Chores