Skip to content

Update flow-go version to fix state mismatch issue - #981

Merged
m-Peter merged 1 commit into
mainfrom
mpeter/update-flow-go-version
Jul 21, 2026
Merged

Update flow-go version to fix state mismatch issue#981
m-Peter merged 1 commit into
mainfrom
mpeter/update-flow-go-version

Conversation

@m-Peter

@m-Peter m-Peter commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Summary by CodeRabbit

  • Bug Fixes

    • Improved trace output accuracy by including complete account state details in prestate and poststate results.
  • Tests

    • Updated expected debugging trace results to reflect additional account information.
    • Temporarily disabled the multicall contract end-to-end test.
  • Chores

    • Updated core and supporting dependency versions for improved compatibility and maintenance.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

The PR upgrades root and test-module dependencies, updates Web3 debug-trace expectations for additional account state fields, and disables the eth_multicall3_contract_test E2E subtest.

Dependency and trace test updates

Layer / File(s) Summary
Upgrade Flow and Go dependencies
go.mod, tests/go.mod
Flow, Cadence, Atree, and golang.org/x/* module versions are upgraded in both module manifests.
Update Web3 trace test coverage
tests/web3js/debug_traces_test.js, tests/e2e_web3js_test.go
Prestate and poststate expectations include additional account fields, and the multicall3 E2E invocation is commented out.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: Bugfix, EVM, Dependencies

Suggested reviewers: zhangchiqing, janezpodhostnik, peterargue

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: bumping flow-go to address the state mismatch issue.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mpeter/update-flow-go-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/e2e_web3js_test.go (1)

89-99: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use t.Skip() instead of commenting out the test invocation.

Commenting out the test invocation causes the t.Run block to execute without any assertions, silently passing. If this test is temporarily disabled, use t.Skip() to explicitly report it as skipped in the test runner output. If the test is permanently obsolete, consider removing the entire t.Run block.

♻️ Proposed refactor to skip the test properly
 	t.Run("deploy multicall3 contract and call methods", func(t *testing.T) {
+		t.Skip("Temporarily disabled: this is a pre-signed contract deployment, that only works before Amsterdam.")
 		// set the Amsterdam hard-fork activation to 24 hours from now
 		evmEmulator.PreviewnetAmsterdamActivation = uint64(time.Now().Add(24 * time.Hour).Unix())
 		defer func() {
 			// set it back to its original value
 			evmEmulator.PreviewnetAmsterdamActivation = uint64(0)
 		}()
-		// this is a pre-signed contract deployment, that only works before
-		// Amsterdam.
-		// runWeb3Test(t, "eth_multicall3_contract_test")
+		runWeb3Test(t, "eth_multicall3_contract_test")
 	})
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/e2e_web3js_test.go` around lines 89 - 99, Replace the commented-out
runWeb3Test invocation inside the “deploy multicall3 contract and call methods”
t.Run block with t.Skip(), so the disabled test is explicitly reported as
skipped while preserving its setup and cleanup behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/e2e_web3js_test.go`:
- Around line 89-99: Replace the commented-out runWeb3Test invocation inside the
“deploy multicall3 contract and call methods” t.Run block with t.Skip(), so the
disabled test is explicitly reported as skipped while preserving its setup and
cleanup behavior.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 305e96f4-6022-4faa-abca-532491e40043

📥 Commits

Reviewing files that changed from the base of the PR and between c293b38 and f18b12e.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • go.mod
  • tests/e2e_web3js_test.go
  • tests/go.mod
  • tests/web3js/debug_traces_test.js

@m-Peter
m-Peter merged commit 9245cc6 into main Jul 21, 2026
2 checks passed
@m-Peter
m-Peter deleted the mpeter/update-flow-go-version branch July 21, 2026 06:11
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants