Skip to content

[Flow EVM] Optimize snapshot traversal for EVM transactions#8169

Draft
m-Peter wants to merge 1 commit into
masterfrom
mpeter/optimize-evm-snapshots-traversal
Draft

[Flow EVM] Optimize snapshot traversal for EVM transactions#8169
m-Peter wants to merge 1 commit into
masterfrom
mpeter/optimize-evm-snapshots-traversal

Conversation

@m-Peter

@m-Peter m-Peter commented Nov 20, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@m-Peter m-Peter self-assigned this Nov 20, 2025
@github-actions

github-actions Bot commented Nov 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter

codecov-commenter commented Nov 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fvm/evm/emulator/state/delta.go 51.72% 7 Missing and 7 partials ⚠️

📢 Thoughts on this report? Let us know!

@m-Peter m-Peter force-pushed the mpeter/optimize-evm-snapshots-traversal branch 3 times, most recently from bd16666 to baf5433 Compare November 20, 2025 13:45
@m-Peter m-Peter marked this pull request as ready for review November 20, 2025 14:48
@m-Peter m-Peter requested a review from a team as a code owner November 20, 2025 14:48
@m-Peter m-Peter marked this pull request as draft November 21, 2025 11:12
@m-Peter m-Peter force-pushed the mpeter/optimize-evm-snapshots-traversal branch from baf5433 to d702582 Compare November 21, 2025 11:14
@m-Peter m-Peter force-pushed the mpeter/optimize-evm-snapshots-traversal branch from d702582 to 93a26e8 Compare November 25, 2025 11:59
@github-actions github-actions Bot added the Stale Label used when marking an issue stale. label Jan 26, 2026
@github-actions github-actions Bot closed this Feb 2, 2026
@m-Peter m-Peter reopened this Feb 2, 2026
@m-Peter m-Peter added Preserve Stale Bot repellent and removed Stale Label used when marking an issue stale. labels Feb 2, 2026
janezpodhostnik
janezpodhostnik reviewed Feb 11, 2026
View reviewed changes

@janezpodhostnik janezpodhostnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly concerned about this.

If DeltaViews are meant for state rolback isolation, then this would break things...

Before I go deeper, can you mention what problem is this solving.

@m-Peter

m-Peter commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator Author

I'm slightly concerned about this.

If DeltaViews are meant for state rolback isolation, then this would break things...

Before I go deeper, can you mention what problem is this solving.

@janezpodhostnik This doesn't affect the functionality of state rollback, it's just an optimization detail. For more info, you can read up on this slack thread: https://flow-foundation.slack.com/archives/C074F78ECNL/p1763489827719909 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@m-Peter m-Peter

Labels

Flow EVM Improvement Performance Preserve Stale Bot repellent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m-Peter @codecov-commenter @janezpodhostnik @vishalchangrani