Skip to content

[Testing] Fix flaky tests exposed by parallel test scheduling - #8640

Open
janezpodhostnik wants to merge 2 commits into
janez/fix-flaky-execution-receipt-waitfrom
janez/fix-flaky-tests-parallel-exposure
Open

[Testing] Fix flaky tests exposed by parallel test scheduling#8640
janezpodhostnik wants to merge 2 commits into
janez/fix-flaky-execution-receipt-waitfrom
janez/fix-flaky-tests-parallel-exposure

Conversation

@janezpodhostnik

@janezpodhostnik janezpodhostnik commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Flaky test fixes for failures that surfaced once slow test packages were scheduled first (heavier contention at the start of a full-suite run), plus one pre-existing tail flake.

  • engine/access/state_stream/backend: widen per-block exec-data liveness waits (1s -> 10s); they timed out under full-suite load.
  • network/alsp/manager RepeatOffender: poll for the first penalty change instead of sleeping exactly one heartbeat interval, which could observe 0 or 2 decays when the heartbeat ticker was delayed.
  • ledger/complete/wal checkpoint test: redraw random payloads on duplicate encoded keys. Keys can be as short as 1 byte (~1/256 collision per pair, ~130 payloads per trie), which made the payload comparison nondeterministic.
  • engine/verification/fetcher/chunkconsumer: assert the multiset instead of the exact receive order in both "receive N" subtests; the consumer's 3 concurrent workers append in nondeterministic order.

All fixes preserve the original assertions' strength. Validation: per-test stress runs (3x-50x, -race where relevant) and clean 10x full-suite campaigns.

Related: #8639


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@janezpodhostnik
janezpodhostnik requested a review from a team as a code owner August 4, 2026 18:37
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a0161551-dc0e-485a-bc28-f34417cc66d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@janezpodhostnik janezpodhostnik changed the title Fix flaky tests exposed by parallel test scheduling [Testing] Fix flaky tests exposed by parallel test scheduling Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants