[Testing] Fix flaky tests exposed by parallel test scheduling - #8640
Open
janezpodhostnik wants to merge 2 commits into
Open
[Testing] Fix flaky tests exposed by parallel test scheduling#8640janezpodhostnik wants to merge 2 commits into
janezpodhostnik wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Kay-Zee
approved these changes
Aug 4, 2026
turbolent
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaky test fixes for failures that surfaced once slow test packages were scheduled first (heavier contention at the start of a full-suite run), plus one pre-existing tail flake.
engine/access/state_stream/backend: widen per-block exec-data liveness waits (1s -> 10s); they timed out under full-suite load.network/alsp/managerRepeatOffender: poll for the first penalty change instead of sleeping exactly one heartbeat interval, which could observe 0 or 2 decays when the heartbeat ticker was delayed.ledger/complete/walcheckpoint test: redraw random payloads on duplicate encoded keys. Keys can be as short as 1 byte (~1/256 collision per pair, ~130 payloads per trie), which made the payload comparison nondeterministic.engine/verification/fetcher/chunkconsumer: assert the multiset instead of the exact receive order in both "receive N" subtests; the consumer's 3 concurrent workers append in nondeterministic order.All fixes preserve the original assertions' strength. Validation: per-test stress runs (3x-50x,
-racewhere relevant) and clean 10x full-suite campaigns.Related: #8639
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.