Optimize iteration over dictionary keys - #269
Merged
Merged
Conversation
The `for k in dict` syntax requires Cadence v1.10+. Updated: - flow-emulator v1.18.0 -> v1.19.0 (ships with Cadence v1.10.0) - cadence v1.9.10 -> v1.10.0 - flow-go-sdk v1.9.16 -> v1.10.0 - Regenerated Go assets Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
joshuahannan
approved these changes
Apr 7, 2026
joshuahannan
left a comment
joshuahannan
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I ran the tests and updated the PR, so everything looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since Cadence v1.10.0 direct iteration over dictionaries is supported, which avoids temporarily constructing an array of all keys.
For contributor use:
masterbranchFiles changedin the Github PR explorer