Release 3.2.8 #217
Merged
Release 3.2.8 #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
onizet
commented
Oct 20, 2025
onizet
commented
- Fix a fatal crash when trying to convert multiple images Cannot convert multiple images #215
- New feature to allow to reference external image instead of embedding them Implement ImageProcessingMode which dictates how images should be handled during conversion #216
- Fix a potential issue on image streams that are disposed too early.
- Support table col with percentage width Table Column Width Styling Not Supported #206
1. Specify an ID in AddImagePart to avoid duplicate key issues when handling multiple images. (#215) 2. Add thread-safe image cache handling
…dled during conversion. (#216) The idea of this commit is to provide a working example of being able to dictate how HtmlToOpenXml should handle images marked as HTTP/HTTPS. I've also provided handling for data uris so that only data URI images can be embedded. Example implementation - taken from a modified form of examples\Demo\Program.cs string inputFile = "C:\\ConvertedHtml.html"; string htmlContent = await File.ReadAllTextAsync(inputFile); string outputPath = "C:\\ConvertedHtml.docx"; using WordprocessingDocument wordDoc = WordprocessingDocument.Create(outputPath, WordprocessingDocumentType.Document); MainDocumentPart mainPart = wordDoc.AddMainDocumentPart(); mainPart.Document = new Document(new DocumentFormat.OpenXml.Wordprocessing.Body()); HtmlConverter htmlConverter = new(mainPart, new DefaultWebRequest()) { ImageProcessing = ImageProcessingMode.LinkExternal }; await htmlConverter.ParseBody(htmlContent); AssertThatOpenXmlDocumentIsValid(wordDoc); mainPart.Document.Save();
…am get disposed too soon.
… MemoryStream, resulting in premature disposal
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.