Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I got in touch (#1677) a month ago about implementing the SAM-kNN Classifier for river. I think the implementation is pretty much ready, let me know what you think!
A couple remarks:
check_emerging_features,check_disappearing_featuresandcheck_radically_disappearing_featuresin 05d2ea2/ 96a5618 as the classifier only works with a consistent feature set. Is this the intended way to go about this or did I miss something?kmeansandkmodes.kmeansis the currently used default method and uses the sklearn implementation.kmodeswould be another library that is not a dependency of river. Can this be implemented using a conditional import only when the option is selected? What is the project's policy on that?Thanks everyone!