Move NUnique to the sketch module
#1692
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e10e3
requested review from
AdilZouitine,
MaxHalford and
smastelini
as code owners
NUnique does not adhere to the Statistic API; its update() method does not have a floating-point number as an input. The functionality of NUnique, with its probabilistic properties, better fits the goals of the sketch module.
e10e3
force-pushed
the
move-nunique-to-sketch
branch
from
6904867 to
bab9976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUnique does not adhere to the univariate statistic abstract class API; its
update()method does not have a number as an input but a string1.The functionality of NUnique, with its probabilistic properties (it has an error rate), better fits the goals of the
sketchmodule. As a matter of fact, the HyperLogLog algorithm it implements is commonly described as a sketch (or a “probabilistic data structure”), the same way as the Bloom filter or the Count-Min sketch.This PR moves the NUnique class to the
sketchmodule.I added type hints to the file while I was at it.
By the way, this is quite a breaking change, what is River's stability policy?
Footnotes
The
_hash()method only accepts a string, theupdate()method does the same transitively. Try giving it a number as its argument. ↩