Origo Tests #24
Open
Origo Tests #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…origo client classes
…http requests. Implemented to checkExistingCallbackSubs
…ilize new httpactionresult wrapper
…owire origo client to make requests and apply logic to results. Add: getFilterById.
…ty null by default.
…me provisional service methods for brainstorming.
…oring event ids and timestamps in json
…ill be the api call for events.
…nts, but gains new events.
… Passing in sample event objects.
…thods to fit interface.
…e. Add: successful authentication request
…e successfully pulls and mock-processes events from origo API
…makeRequest(). delete: unused origocontroller. add: authenticateAndRetry
…o incompatible with PhotoFile
…te authentication loop.
…service / httpclient
jonnyhoffer
reviewed
Aug 28, 2024
| - Provided by Origo. | ||
| - Available in Origo Management Portal. | ||
| - `Origo.contentType` | ||
| - Used for request headers - see documentation. |
There was a problem hiding this comment.
Is there a situation where this isn't always the same value?
There was a problem hiding this comment.
Not unless there was a change in API Version. Would you like these properties to stay filled?
There was a problem hiding this comment.
For the moment, I've included the properties that don't change in the existing application.properties file.
There was a problem hiding this comment.
Made a little mistake. While the content-type shouldn't change except for a couple requests (Already accounted for in OrigoClient methods), All of the API links change from test API to the Production API. I'll add the production API links to the Application.properties.
jonnyhoffer
reviewed
Aug 30, 2024
jonnyhoffer
reviewed
Aug 30, 2024
src/main/groovy/com/cloudcard/photoDownloader/OrigoStorageService.groovy
Outdated
Show resolved
Hide resolved
jonnyhoffer
reviewed
Aug 30, 2024
src/main/groovy/com/cloudcard/photoDownloader/TouchNetClient.groovy
Outdated
Show resolved
Hide resolved
…efactors, updated readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Tests have all passed.
Refactored code has been tested live with SQS feed and Origo API calls.