feat: add CI workflow for running tests #2416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GitHub Actions workflow to run bun test on pushes to main and PRs - Uses same Bun setup pattern as existing Supabase workflows - Runs tests across all packages in monorepo using existing test script Co-Authored-By: [email protected] <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
.github/workflows/test.yml
Outdated
| bun-version: latest | ||
|
|
||
| - name: Install dependencies | ||
| run: bun install --frozen-lockfile |
Contributor
There was a problem hiding this comment.
The --frozen-lockfile flag is specific to Yarn and not supported in Bun. For Bun, the equivalent flag is --frozen, which ensures dependencies are installed exactly as specified in the lockfile without updating it.
Suggested change
| run: bun install --frozen-lockfile | |
| run: bun install --frozen |
This will maintain the same intended behavior of preventing lockfile updates during CI runs.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
.github/workflows/test.yml
Outdated
|
|
||
| - uses: oven-sh/setup-bun@v1 | ||
| with: | ||
| bun-version: latest |
Contributor
There was a problem hiding this comment.
Pin the Bun version instead of using 'latest' for build consistency.
Suggested change
| bun-version: latest | |
| bun-version: 1.0.25 |
- Change --frozen-lockfile to --frozen (correct for Bun) - Pin Bun version to 1.1.38 instead of latest for consistency - Addresses feedback from Graphite and Ellipsis bots Co-Authored-By: [email protected] <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
- Add IGNORED_DIRECTORIES to constants package to fix import error - Add timeout (30s), bail, and coverage options to prevent hangs - Fix SandboxManager constructor calls in tests to include required EditorEngine parameter - Addresses CI test hanging issue that was causing 30+ minute timeouts Co-Authored-By: [email protected] <[email protected]>
- Fix --bail 1 flag that was being interpreted as filter instead of bail option - Change to --bail which defaults to 1 and works correctly - Upgrade Bun version from 1.1.38 to 1.2.18 for better compatibility - Fix --frozen-lockfile to --frozen for Bun 1.2.x - Verified locally that tests now execute properly instead of being filtered out Co-Authored-By: [email protected] <[email protected]>
- Remove unused 'editor.panels.edit.tabs.chat.mode.tooltip' key from es.json - Fixes localization test failure that was preventing CI from passing - Key was not used anywhere in codebase, confirmed via search Co-Authored-By: [email protected] <[email protected]>
- Assign testMockSession to testManager.session.session - Fixes 'should list files recursively' test failure - Ensures listFilesRecursively can access mocked readdir function Co-Authored-By: [email protected] <[email protected]>
- Add explicit check that mock session is properly assigned - Helps debug CI vs local test execution differences - Ensures session is connected before calling listFilesRecursively Co-Authored-By: [email protected] <[email protected]>
- Use runInAction for MobX observable assignments to prevent strict mode violations - Fix test expectations to match SandboxFile object structure (content2.content) - Add missing readOrFetchBatch method to FileSyncManager mocks - Add disconnect method to all session mocks to prevent cleanup errors - All 8 sandbox tests now pass locally with proper mock handling Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description is being written. Please check back in a minute.
Devin Session: https://app.devin.ai/sessions/da64f2c372844e75ab724b039076305d
Important
Adds CI workflow for running tests using GitHub Actions and enhances test setup and constants.
.github/workflows/test.ymlto run tests onpushandpull_requesttomainbranch.ubuntu-latest,actions/checkout@v4, andoven-sh/setup-bun@v1withbun-version: 1.2.18.bun install --frozenand runs tests withbun test --timeout 30000 --bail --coverage.runInActionfrommobxinsandbox.test.tsto set up sessions for tests.readOrFetchBatchanddisconnectinsandbox.test.ts.sandbox.test.ts.IGNORED_DIRECTORIEStofiles.tsfor directory exclusion in tests.This description was created by
for f9a7a01. You can customize this summary. It will automatically update as commits are pushed.