remove mlir usePropertiesForAttributes option as it is deprecated with option of 0 #3352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sunny Anand <[email protected]>
Member
|
This PR in LLVM did some updates when removing usePropertiesForAttributes: llvm/llvm-project#123505, it may help us to know where we need to change in onnx-mlir also. In my understanding, we now access attributes via properties, for example, instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discourse.llvm.org/t/rfc-deprecating-usepropertiesforattributes-0/87536/9
https://mlir.llvm.org/docs/ReleaseNotes/