Conversation
gongsu832
commented
Feb 5, 2026
gongsu832
commented
- upgrade dev base image from Ubuntu jammy to noble
- upgrade usr base image from RedHat ubi8 to ubi9
|
amd64 build failed likely because an s390x |
|
@jenkins-droid test this please |
1 similar comment
|
@jenkins-droid test this please |
gongsu832
force-pushed
the
upgrade_base_images
branch
2 times, most recently
from
1e4b6c3 to
5962235
Compare
- upgrade usr base image from RedHat ubi8 to ubi9 Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
interpreter Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
- don't remove python3 on ubi9 which dnf depends on Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
ONNX_GEN_PB_TYPE_STUBS Signed-off-by: Gong Su <gong_su@hotmail.com>
not protobuf. So proceed with protobuf v33.5 Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
Signed-off-by: Gong Su <gong_su@hotmail.com>
gongsu832
force-pushed
the
upgrade_base_images
branch
from
5962235 to
6eee0d0
Compare
|
|
||
| # Install bazel | ||
| ARG BAZEL_VERSION=6.5.0 | ||
| ARG BAZEL_VERSION=7.4.1 |
There was a problem hiding this comment.
Its best if we can go to the latest bazel version. s390x porting work is started and I will request your guidance here. I will setup a call with Andreas Krebbel and you so that as an expert you can help shape and guide that work. The constant patching we need to do for bazel and protobuf upgrade should not be onnx-mlir responsibility.
| # | ||
| # Fix protoc-gen-upb_minitable_stage0 segfault in | ||
| # _upb_DefPool_SetPlatform on s390x until upstreamed | ||
| # |
There was a problem hiding this comment.
With my pr and older protobuf version I had similar issues and required different patching as you noted in my pr.
| # built as a tool dependency. If abseil is being built as a target | ||
| # dependency, we would use --per_file_copt instead. | ||
| # | ||
| && sed -i -e 's/"rules_python", version = "1.6.0"/"rules_python", version = "1.8.0"/g' \ |
There was a problem hiding this comment.
Same comment as above about patching for s390x
Sunny-Anand
left a comment
Sunny-Anand
left a comment
There was a problem hiding this comment.
Can you also update the root CMakelists so that it is clear what now is the minimum cmake level as this is now a forced requirement from onnx.
https://github.com/onnx/onnx-mlir/pull/3370/changes#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a
Also can you update the requirements.txt with the correct required levels for the packages.
Thanks for the pr.
2 participants
