A pass to set some attribute to discardable#3387
Open
chentong319 wants to merge 6 commits intoonnx:mainfrom
Open
A pass to set some attribute to discardable#3387chentong319 wants to merge 6 commits intoonnx:mainfrom
chentong319 wants to merge 6 commits intoonnx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decorative attributes, such as onnx_node_name, may prevent CSE on two otherwise identical operations. This PR add a pass before CSE for user to turn those attributes into discardable attributes, according to the suggestion from Copilot.
However, I found that the discardable attribute still interference with CSE. Current implementation is simple removal of the attributes.
Attributes are controlled with option,
--discardable-attrs, as a list of strings. The default value is "onnx_node_name". You may provide names of other decorative attributes.