Skip to content

Modernize pass instrument#3395

Open
juhyunbae17 wants to merge 2 commits intoonnx:mainfrom
juhyunbae17:modernize_pass_instrument
Open

Modernize pass instrument#3395
juhyunbae17 wants to merge 2 commits intoonnx:mainfrom
juhyunbae17:modernize_pass_instrument

Conversation

@juhyunbae17
Copy link
Collaborator

This PR is to modernize Instrument pass. Following is included

  • definition of options moves to .td and options will be generated by TableGen
  • change multi-positional createInstrumentPass() to single positional so that its declaration and pass registration code can be generated by TableGen instead of having explicit declaration of it alongside TableGen already used in this Instrument Pass.

Signed-off-by: Juhyun Bae <juhyun.bae@ibm.com>
Signed-off-by: Juhyun Bae <juhyun.bae@ibm.com>
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants