Get windows power setting name w. guid#311
Closed
Conversation
jeremyfowers
approved these changes
Apr 21, 2025
Collaborator
jeremyfowers
left a comment
jeremyfowers
left a comment
There was a problem hiding this comment.
Thanks for the contribution @shcho1118, and thanks @amd-pworfolk for reviewing!
There is one CI test failing… it seems to be unrelated to the change in this PR. I will investigate that tomorrow so that we can merge this PR.
Collaborator
|
After some investigation, my conclusion is that the contributed code is somehow incompatible with Windows Server (which is where the CI test is running). I don't have any great ideas about how to debug, though. |
Collaborator
|
Closing PR since Lemonade SDK has moved to another repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #310
The previous script doesn't seem to work as intended if the system language is not English.
I changed it to parse windows power policy guid and match it to an English name and return it instead.