Expose label grid functions for custommap/YAML profiles#1477
Closed
phanecak-maptiler wants to merge 136 commits into
Closed
Expose label grid functions for custommap/YAML profiles#1477phanecak-maptiler wants to merge 136 commits into
phanecak-maptiler wants to merge 136 commits into
Conversation
…h (needed only for test branch)
Full logs: https://github.com/onthegomap/planetiler/actions/runs/27505499244 |
msbarry
reviewed
Feb 20, 2026
Comment on lines
+17
to
+18
| @JsonProperty("point_label_grid_pixel_size") PointLabelGridPixelSize pointLabelGridPixelSize, | ||
| @JsonProperty("point_label_grid_limit") PointLabelGridLimit pointLabelGridLimit, |
Contributor
There was a problem hiding this comment.
Let's make a single "point_label_grid" attribute that is a struct with "pixel_size" and "limit" attrbitutes. "pixel_size" and "limit" should eventually be able to just be a number, value+minzoom, or expression based on feature attributes and zoom, but if we just support value+minzoom for now then we can add support for other variants later.
point_label_grid:
pixel_size:
minzoom: 8
value: 32
limit:
minzoom: 8
value: 64
Contributor
Author
There was a problem hiding this comment.
Adjusted.
Side note: But kept maxzoom naming, since that matches naming of parameters in setPointLabelGridPixelSize() and setPointLabelGridLimit().
Contributor
|
Also could you add the new config fields we land on here and the new "id" field from #1469 to custommap README and planetiler.schema.json file? |
msbarry
reviewed
Mar 6, 2026
| @CsvSource({ | ||
| "sort_key: 100 }, 100", | ||
| "sort_key: ${ feature.id }, 1", | ||
| "sort_key_descending: 100 }, -101", |
Contributor
There was a problem hiding this comment.
I don't quite follow why do these have a } ?
Contributor
Author
There was a problem hiding this comment.
Hmm, I guess some typo. Removed.
msbarry
reviewed
Mar 6, 2026
Comment on lines
+2011
to
+2012
| <TEST INPUT> | ||
| """.replace("<TEST INPUT>", input); |
Contributor
There was a problem hiding this comment.
Minor:
Suggested change
| <TEST INPUT> | |
| """.replace("<TEST INPUT>", input); | |
| %s | |
| """.formatted(input); |
Contributor
Author
There was a problem hiding this comment.
Yup, nicer/better. Thanks. Adjusted.
msbarry
reviewed
Mar 6, 2026
Comment on lines
+112
to
+116
| processors.add(makeFeatureProcessor(feature.pointLabelGrid(), PointLabelGrid.class, | ||
| (f, a) -> { | ||
| f.setPointLabelGridPixelSize(ZoomFunction.maxZoom(a.pixelSize().maxZoom(), a.pixelSize().value())); | ||
| f.setPointLabelGridLimit(ZoomFunction.maxZoom(a.limit().maxZoom(), a.limit().value())); | ||
| })); |
Contributor
There was a problem hiding this comment.
These could technically be set independently. Could we break this up into 2 feature processors, one for pixelsize and one for limit?
Contributor
Author
There was a problem hiding this comment.
Adjusted.
|
|
|
Contributor
Author
|
Sorry, merged my testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes "label grid" related functions for custommap/YAML profiles:
pointLabelGridPixelSize()pointLabelGridLimit()sortKey()sortKeyDescending()Those are needed for layers with many points for "label grid" point density limiting.
Usage example: