feat(auth): move JWT auth settings to DB-backed security settings - #14153
Open
nmgarza5 wants to merge 7 commits into
Open
feat(auth): move JWT auth settings to DB-backed security settings#14153nmgarza5 wants to merge 7 commits into
nmgarza5 wants to merge 7 commits into
Conversation
Contributor
Greptile SummaryThe PR moves external JWT verification settings from environment-only configuration into DB-backed security settings while retaining environment precedence.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant Admin
participant API as Security Settings API
participant DB as security_settings
participant Auth as JWT Authentication
participant Guard as SSRF URL Guard
participant IdP as IdP Key Endpoint
Admin->>API: PUT JWT settings
API->>API: Reject environment-pinned fields
API->>Guard: Validate DB-configured key URL
API->>DB: Store settings and audit changes
Auth->>DB: Load effective security settings
alt URL pinned by environment
Auth->>IdP: Fetch operator-controlled URL
else URL stored in database
Auth->>Guard: Validate URL and SSRF policy
Guard->>IdP: HTTPS fetch to validated IP
end
IdP-->>Auth: PEM or JWKS
Auth->>Auth: Verify signature, audience, and issuer
Reviews (8): Last reviewed commit: "fix(security): hold https_only across ev..." | Re-trigger Greptile |
Contributor
|
Preview Deployment
|
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
Author
2 tasks
justin-tahara
approved these changes
Aug 21, 2026
nmgarza5
force-pushed
the
nikg/jwt-settings-db-move
branch
from
August 22, 2026 00:02
a5aec7c to
f9eaf61
Compare
Contributor
|
Full-stack Preview (frontend + backend)
Sign in with GitHub as an |
Contributor
Author
Contributor
Author
Contributor
🖼️ Visual Regression Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #14151 (stacked on it): moves the JWT auth config off env vars and into the Security & Hardening settings, per the customer thread.
How Has This Been Tested?
Additional Options