Additional ACL Tests + Slackbot fix #4430
Merged
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors Slack credential handling, enhances ACL testing, and improves tenant-awareness in group sync operations.
- /backend/ee/onyx/external_permissions/slack/doc_sync.py: Switches to a credentials provider; ensure channel IDs in doc_metadata always exist in channel_permissions to avoid KeyErrors.
- /backend/ee/onyx/external_permissions/slack/group_sync.py: Adds a tenant_id parameter, though it is not yet utilized.
- /backend/onyx/connectors/slack/connector.py: Updates message filtering to exclude bots with "DanswerBot Testing", revising previous filter logic.
- /backend/ee/onyx/external_permissions/sync_params.py & tests: Integrates Slack group sync into the sync map and refines ACL test setups for robust permission checks.
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
evan-danswer
approved these changes
Apr 3, 2025
backend/tests/integration/connector_job_tests/slack/test_permission_sync.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1732/add-comprehensive-test-for-acls
Fixes https://linear.app/danswer/issue/DAN-1753/fix-slack-connector-perm-group-syncing
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.