Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting default search assistant #4438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Apr 2, 2025

Description

^

How Has This Been Tested?

Tested search assistant locally.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Weves Weves requested a review from a team as a code owner April 2, 2025 23:32
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 11:35pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the default search assistant persona in backend/onyx/seeding/personas.yaml by increasing the number of document chunks to 25 and disabling the LLM relevance filter for safer query processing.

  • Updated default "Search" persona by increasing num_chunks from 10 to 25.
  • Disabled llm_relevance_filter to prevent rate limit issues with some LLM providers.
  • Verify that increased context does not trigger token overflows or degrade response quality.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant