Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link cache validation #4445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Link cache validation #4445

wants to merge 1 commit into from

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Apr 3, 2025

Description

Fixes https://linear.app/danswer/issue/DAN-1743/chat-sessions-disappearing-after-navigating-to-the-admin-panel-and

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 7:49pm

@pablonyx pablonyx changed the title update Link cache validation Apr 3, 2025
@pablonyx pablonyx marked this pull request as ready for review April 3, 2025 19:46
@pablonyx pablonyx requested a review from a team as a code owner April 3, 2025 19:46
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Replaced the Next.js <Link> component with a native <a> element in web/src/components/UserDropdown.tsx to force a full page reload and properly reinitialize state, addressing caching issues causing disappearing chat sessions.

  • Updated DropdownOption in /web/src/components/UserDropdown.tsx to use <a> instead of <Link>.
  • Ensures a full page transition to resolve stale context and state issues.
  • Acknowledges potential performance trade-offs in favor of reliability.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant