feat: Vertex AI support #4458
feat: Vertex AI support #4458
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces support for the Gemini/VertexAI LLM Provider by updating configuration interfaces, backend completion calls, and UI components to properly handle file-based credentials and streamline provider-specific options.
- Updated backend/onyx/llm/chat_llm.py to conditionally inject 'vertex_credentials' into the Litellm call for vertex_ai.
- Extended backend/onyx/llm/interfaces.py by adding an optional 'credentials_file' in LLMConfig.
- Added Gemini/VertexAI support in backend/onyx/llm/llm_provider_options.py with drag-and-drop custom config keys.
- Modified web/src/app/admin/configuration/llm/LLMConfiguration.tsx and LLMProviderUpdateForm.tsx for simplified UI handling of VertexAI.
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
8 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| disabled={existingLlmProvider ? true : false} | ||
| /> | ||
| )} | ||
| <TextFormField |
There was a problem hiding this comment.
I def agree that hideAdvanced shouldn't control this, but I think we still need a way to hide this. Basically, when a user first comes to the app, we don't want to ask them to put in a name, it slightly increases friction (see ApiKeyForm)
There was a problem hiding this comment.
Ah, you're right. I think I was a little bullish with the removal of this field. I've added it back (and renamed it to be a little bit more aligned with its purpose).
I've renamed it to firstTimeConfiguration. Do you think that's an appropriate name here? It's only used in ApiKeyForm, which I believe is only shown during first time configurations?
…ore complex `CustomConfigKey` types
raunakab
force-pushed
the
feat/vertexai-support
branch
from
03981de to
8c0bee9
Compare
| disabled={existingLlmProvider ? true : false} | ||
| /> | ||
| )} | ||
| <TextFormField |
Description
This PR adds support for the Gemini/VertexAI LLM Provider.
Addresses https://linear.app/danswer/issue/DAN-1704/built-in-gemini-vertex-ai-support.
How Has This Been Tested?
Primarily UI based changes; tested manually to make sure registration/deletion works.