unconditionally set completion

[evan-onyx]

Description

Should fix drive id not set in checkpoint; previously when a user failed to index a folder (which is fairly common due to permissions issues) the folder id was not set in the checkpoint. The necessary information for the checkpoint is yielded on error too,

How Has This Been Tested?

Tests tbd

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

• This PR should be backported (make sure to check that the backport attempt succeeds)
• [Optional] Override Linear Check

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
internal-search	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 5, 2025 4:09am

[greptile-apps]

PR Summary

The changes ensure that the checkpoint is updated with completion and folder ID information even in error scenarios, helping maintain consistent state across indexing attempts.

• Updated logic in backend/onyx/connectors/google_drive/connector.py to unconditionally yield checkpoint completion info on errors.
• Ensures folder IDs are recorded even when permissions issues cause file indexing failures.
• Addresses potential issues where file.drive_file may miss MODIFIED_TIME without overwriting valid state.
• Enhances resilience of error handling in the Google Drive connector checkpointing mechanism.

_{1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

logic: Ensure file.drive_file always contains MODIFIED_TIME even when file.error is set. Otherwise may raise runtime errors.

Suggested change

	checkpoint.completion_map[file.user_email].update(
	stage=file.completion_stage,
	completed_until=datetime.fromisoformat(
	file.drive_file[GoogleFields.MODIFIED_TIME.value]
	).timestamp(),
	completed_until_parent_id=file.parent_id,
	)
	if file.error is None:
	checkpoint.completion_map[file.user_email].update(
	stage=file.completion_stage,
	completed_until=datetime.fromisoformat(
	file.drive_file[GoogleFields.MODIFIED_TIME.value]
	).timestamp(),
	completed_until_parent_id=file.parent_id,
	)