Skip to content

Update resource limits #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025
Merged

Update resource limits #4461

merged 2 commits into from
Apr 5, 2025

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Apr 5, 2025

Description

Ref https://linear.app/danswer/issue/DAN-1670/resolve-alation-instance-crashing

How Has This Been Tested?

Tested running compose locally with docker compose -f docker-compose.dev.yml -f docker-compose.resources.yml -p onyx-stack up -d --build --force-recreate

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Weves Weves requested a review from a team as a code owner April 5, 2025 22:58
Copy link

vercel bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 5, 2025 10:58pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The PR updates resource limits in the Docker Compose file and adds explicit environment variable exports in the nginx startup script to enhance debugging clarity.

  • deployment/docker_compose/docker-compose.resources.yml: Updated limits for background, nginx, api_server, inference_model_server, indexing_model_server, and relational_db to mitigate OOM issues.
  • deployment/data/nginx/run-nginx.sh: Added explicit exports and echo statements for API and web server hosts, enhancing visibility during startup and debugging.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weves Weves merged commit cf6ff3c into main Apr 5, 2025
8 of 11 checks passed
@Weves Weves deleted the update-resource-limits branch April 5, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant