Skip to content

Small tweaks to thinking #4462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged

Small tweaks to thinking #4462

merged 1 commit into from
Apr 6, 2025

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Apr 6, 2025

Description

^

Screenshot 2025-04-06 at 12 32 53 PM

Fixes https://linear.app/danswer/issue/DAN-1711/review-fix-up-ferdinands-thinking-mode-ui-pr

How Has This Been Tested?

Tested locally

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Weves Weves requested a review from a team as a code owner April 6, 2025 19:33
Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2025 7:35pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR introduces subtle enhancements to the ThinkingBox component with updated import paths, improved transition state management, and refined CSS for smoother dark mode effects. Minor updates in Messages.tsx and AgenticMessage.tsx adjust thinking token handling and import paths accordingly.

  • Updated /web/src/app/chat/message/thinkingBox/ThinkingBox.tsx to add an isTransitioning state with delays for smoother expand/collapse.
  • Enhanced /web/src/app/chat/message/thinkingBox/ThinkingBox.css with refined dark mode transitions and border handling.
  • Adjusted thinking token extraction and rendering in /web/src/app/chat/message/Messages.tsx and /web/src/app/chat/message/AgenticMessage.tsx.

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weves Weves merged commit 6a13401 into main Apr 6, 2025
10 of 13 checks passed
@Weves Weves deleted the small-thinking-tweak branch April 6, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant