Skip to content

Add more options to dev compose file #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Add more options to dev compose file #4469

merged 1 commit into from
Apr 7, 2025

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Apr 7, 2025

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Weves Weves requested a review from a team as a code owner April 7, 2025 17:03
Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 5:03pm

@Weves Weves merged commit 614d0f8 into main Apr 7, 2025
9 of 11 checks passed
@Weves Weves deleted the add-to-compose-file branch April 7, 2025 17:03
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Overall, this PR adds four new PostgreSQL connection pooling environment variables to the api_server service in the development Docker Compose file.

  • Modified /deployment/docker_compose/docker-compose.dev.yml to include POSTGRES_API_SERVER_POOL_SIZE, POSTGRES_API_SERVER_POOL_OVERFLOW, POSTGRES_IDLE_SESSIONS_TIMEOUT, and POSTGRES_POOL_RECYCLE.
  • Default values remain empty, so explicit configuration should be considered to avoid unintended behavior.
  • Ensure changes are documented and aligned with backend connection pooling tests.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant