Skip to content

chore: Add pyright configuration values to help it find the venv #4471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Apr 7, 2025

Description

This PR adds two values to the backend/pyproject.toml to help pyright find the path to the .venv file.

Addresses: https://linear.app/danswer/issue/DAN-1704/built-in-gemini-vertex-ai-support.

How Has This Been Tested?

pyright works. No further testing required.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@raunakab raunakab requested a review from a team as a code owner April 7, 2025 19:44
Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 7:46pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates backend/pyproject.toml by adding a new [tool.pyright] block and reformatting the [tool.ruff] configuration for consistency.

  • Added [tool.pyright] with venvPath = "../.." and venv = ".venv" to help Pyright locate the virtual environment.
  • Reformatted the [tool.ruff] 'select' array from multiline to inline.
  • Ensure the ../.. path correctly reflects the actual project structure.

💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@raunakab
Copy link
Contributor Author

raunakab commented Apr 8, 2025

Closing since we're using pylsp with type-checking provided by the mypy plugin instead!

@raunakab raunakab closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant