Add latency metrics #4472
Merged
Add latency metrics #4472
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
force-pushed
the
monitoring_metrics
branch
from
e0993ff to
8c42f46
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR integrates latency metrics across the chat and authentication flows to support monitoring in Grafana.
- backend/onyx/server/query_and_chat/chat_backend.py: Introduces start-time tracking and logs document retrieval latency when a 'top_documents' key is present; ensure duplicate logs aren’t triggered inadvertently.
- backend/onyx/auth/users.py: Applies
log_function_timeon crucial async methods (e.g.,oauth_callbackandauthenticate) to capture performance data. - backend/onyx/chat/process_message.py: Removes inline timing calls to streamline measurement via centralized telemetry.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
evan-danswer
reviewed
Apr 7, 2025
| @@ -448,6 +449,10 @@ def stream_generator() -> Generator[str, None, None]: | |||
| ), | |||
| is_connected=is_connected_func, | |||
| ): | |||
| if isinstance(packet, dict) and "top_documents" in packet: | |||
There was a problem hiding this comment.
this seems problematic, no? stream_chat_message yields strs not dicts?
tim-dim
pushed a commit
to grantgpteu/grantgpt-dev
that referenced
this pull request
Apr 9, 2025
* k * update * Update chat_backend.py nit --------- Co-authored-by: evan-danswer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1777/track-latency-metrics
These should give us enough information to construct latency metrics in Grafana
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.