Add stuff to better avoid bot-detection in web connector #4479
+275
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves the web connector's ability to avoid bot detection by incorporating randomized human-like delays, enhancing Playwright context realism, and adding a robust retry mechanism.
- Modified
/backend/onyx/connectors/web/connector.pyto incorporate random delays and realistic browser settings. - Added a cookie handling mechanism to mitigate bot detection.
- Implemented exponential backoff with Playwright restart on failures.
- Validated changes through tests in
/backend/tests/daily/connectors/web/test_web_connector.py.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
evan-danswer
approved these changes
Apr 8, 2025
| session.headers.update(DEFAULT_HEADERS) | ||
|
|
||
| # Add a random delay to mimic human behavior | ||
| time.sleep(random.uniform(0.1, 0.5)) |
| } | ||
| ) | ||
|
|
||
| # Add a script to modify navigator properties to avoid detection |
| except Exception as e: | ||
| logger.debug(f"Failed to add cookie {cookie['name']} for {domain}: {e}") | ||
| except Exception as e: | ||
| logger.debug(f"Failed to handle cookies for {url}: {e}") |
There was a problem hiding this comment.
Could be an exception log?
| timeout=30000, # 30 seconds | ||
| ) | ||
| # Add random mouse movements and scrolling to mimic human behavior | ||
| page.mouse.move(random.randint(100, 700), random.randint(100, 500)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1782/resolve-parsing-of-certain-websites-w-web-connector
How Has This Been Tested?
Tested with a previously broken website.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.