Skip to content

Fix startup w/ seed_db #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Fix startup w/ seed_db #4481

merged 1 commit into from
Apr 8, 2025

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Apr 8, 2025

Description

The DB was not getting initialized before calling seed_db -> failures on startup if you had env-variable based seeding enabled.

Fixes https://linear.app/danswer/issue/DAN-1784/fix-seed-db-failures

How Has This Been Tested?

Tested locally w/ env-variable based seeding.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Weves Weves requested a review from a team as a code owner April 8, 2025 18:40
Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 6:44pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The changes ensure that the database is properly initialized before invoking seed_db to prevent startup failures when seeding is enabled.

  • Updated /backend/ee/onyx/main.py (EE) to wrap the base lifespan in an async context that calls seed_db after DB initialization.
  • Removed the redundant seed_db call to avoid race conditions.
  • Modified /backend/onyx/main.py (base) to accept an optional lifespan_override for flexible initialization.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weves Weves added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 634d990 Apr 8, 2025
12 of 14 checks passed
tim-dim pushed a commit to grantgpteu/grantgpt-dev that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants