Shore up multi tenant tests #4484
Merged
+266
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances multi-tenant tests by improving organization and clarity while introducing helper functions for shared setup. It also adds debugging prints that risk exposing sensitive data and may cause unintended behavior.
- /backend/tests/integration/common_utils/managers/chat.py: Added prints for headers and cookies; risk if user_performing_action is None and exposing sensitive data.
- /backend/ee/onyx/server/middleware/tenant_tracking.py: Introduced debug prints and a problematic finally block that overrides intended returns.
- /backend/tests/integration/multitenant_tests/invitation/test_user_invitation.py: Split invitation tests for better separation of roles and flows.
- /backend/tests/integration/multitenant_tests/syncing/test_search_permissions.py: Moved common tenant setup into a helper; ensure reset_multitenant isolates concurrent runs.
- /backend/tests/integration/multitenant_tests/tenants/test_tenant_creation.py: Expanded tenant creation tests; consider unique identifiers to avoid collisions.
5 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
pablonyx
force-pushed
the
shore_up_multitenant
branch
from
07c8050 to
9f5a19d
Compare
evan-danswer
approved these changes
Apr 14, 2025
| @@ -130,6 +128,7 @@ export function LLMProviderUpdateForm({ | |||
| initialValues={initialValues} | |||
| validationSchema={validationSchema} | |||
| onSubmit={async (values, { setSubmitting }) => { | |||
| alert("onSubmit"); | |||
| </> | ||
| )} | ||
|
|
||
| {/* NOTE: this is above the test button to make sure it's visible */} | ||
| {testError && <Text className="text-error mt-2">{testError}</Text>} | ||
|
|
||
| <div className="flex w-full mt-4"> | ||
| <Button type="submit" variant="submit"> | ||
| <Button | ||
| onClick={() => alert(JSON.stringify(formikProps.errors))} |
There was a problem hiding this comment.
intentional alert? or no
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
* update * fix * finalize` * remove unnecessary prints * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1770/testing-for-cloud-flows
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.