pass through various id's and log them in the model server for better… #4485
+127
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces enhanced traceability by passing unique request and tenant IDs throughout the indexing and model server flow, with structured IDs added for better correlation across logs and metrics.
- backend/onyx/background/indexing/run_indexing.py: Adds attempt_id, request_id, and structured_id to IndexAttemptMetadata and generates new IDs per batch.
- backend/ee/onyx/server/middleware/tenant_tracking.py: Implements multi-method tenant ID extraction but has a logic flaw in _get_tenant_id_from_request’s finally block.
- backend/onyx/indexing/indexing_pipeline.py: Passes tenant_id and request_id when invoking embed_chunks_with_failure_handling.
- backend/onyx/indexing/embedder.py: Updates embed_chunks signature to accept tenant_id/request_id; note fallback title embedding lacks tenant_id.
- Additional updates (middleware, chunker, models): Ensure consistent tenant/request ID propagation to support improved logging and observability.
10 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
pablonyx
approved these changes
Apr 10, 2025
tim-dim
pushed a commit
to grantgpteu/grantgpt-dev
that referenced
this pull request
Apr 10, 2025
onyx-dot-app#4485) * pass through various id's and log them in the model server for better tracking * fix test --------- Co-authored-by: Richard Kuo (Onyx) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tracking
Description
Fixes DAN-1785.
https://linear.app/danswer/issue/DAN-1785/create-request-ids-during-indexing-and-handle-in-model-server
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.