Skip to content

Remove confusing text#5468

Merged
yuhongsun96 merged 1 commit intomainfrom
sources
Sep 22, 2025
Merged

Remove confusing text#5468
yuhongsun96 merged 1 commit intomainfrom
sources

Conversation

@yuhongsun96
Copy link
Contributor

@yuhongsun96 yuhongsun96 commented Sep 22, 2025

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Summary by cubic

Removed the "+N" remaining sources count from the cited sources toggle to avoid confusion and visual clutter. The toggle now only shows unique source icons alongside the "Sources" label.

@yuhongsun96 yuhongsun96 requested a review from a team as a code owner September 22, 2025 22:37
@vercel
Copy link

vercel bot commented Sep 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
internal-search Building Building Preview Comment Sep 22, 2025 10:37pm

@yuhongsun96 yuhongsun96 merged commit e38f79d into main Sep 22, 2025
15 of 19 checks passed
@yuhongsun96 yuhongsun96 deleted the sources branch September 22, 2025 22:37
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR simplifies the UI in the CitedSourcesToggle component by removing the confusing "+N remaining" count that displayed how many additional sources existed beyond the first 2 unique icons shown. The component previously had complex logic to calculate and display this count based on the number of citations and document map size, with conditional logic that could be misleading to users.

The change removes lines 124-126 that rendered this count indicator while preserving the core functionality of displaying up to 2 unique source icons followed by the "Sources" label. This aligns with the existing logic that already limits the display to 2 unique icons (controlled by the break condition when uniqueIcons.length >= 2). The component integrates with the broader chat interface where users can click to expand and see all available sources, making the specific count less critical for the user experience.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only removes UI elements without affecting core functionality
  • Score reflects the simple nature of removing confusing display logic while maintaining all underlying source handling capabilities
  • No files require special attention as this is a straightforward UI simplification

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

brijsiyag-meesho pushed a commit to brijsiyag-meesho/onyx that referenced this pull request Sep 23, 2025
razvanMiu pushed a commit to eea/danswer that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant