chore(chat): consolidate chat message whitespacing style#8696
chore(chat): consolidate chat message whitespacing style#8696
Conversation
|
Preview Deployment
|
Greptile SummaryThis PR consolidates chat message spacing by moving whitespace control from individual message components to the ChatUI container. The container now uses Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 15015a4 |
Additional Comments (1)
|
🖼️ Visual Regression Report
|
d1ac9bc to
14e2002
Compare
There was a problem hiding this comment.
6 issues found across 90 files (changes from recent commits).
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="backend/onyx/tools/tool_implementations/python/python_tool.py">
<violation number="1">
P2: Raising on StreamErrorEvent skips the cleanup of staged files/generate files, which can leak Code Interpreter files. Handle the error without bypassing cleanup (e.g., store the error and run cleanup in a finally block).</violation>
</file>
<file name="web/src/sections/modals/PreviewModal/variants/csvVariant.tsx">
<violation number="1">
P2: CSV parsing uses simple string split, which breaks on quoted commas and other valid CSV cases. Use a real CSV parser (or a parser that handles quoted fields) to avoid incorrect column counts and misrendered data.</violation>
</file>
<file name="backend/requirements/model_server.txt">
<violation number="1">
P2: This requirements .txt file is documented as generated; updates should be made in pyproject.toml and regenerated to avoid drift. Please update the source dependency spec and re-export requirements instead of editing this file directly.</violation>
</file>
<file name="web/src/sections/modals/PreviewModal/variants/shared.tsx">
<violation number="1">
P2: Avoid nesting a Button inside an <a>; it creates invalid interactive markup and can interfere with activation/accessibility. Render a single element by using the Button’s link props (href/download) instead of wrapping it in an anchor.</violation>
</file>
<file name="extensions/chrome/src/pages/panel.js">
<violation number="1">
P2: Unhandled throw from `getIframeOrigin()` — if a `TAB_URL_UPDATED` message arrives before `setIframeSrc()` is called (initialization is async), `new URL(iframe.src)` will throw an uncaught exception. The `handleMessage` function correctly wraps this call in try-catch; this handler should do the same to fail closed.</violation>
</file>
<file name="backend/onyx/tools/tool_implementations/python/code_interpreter_client.py">
<violation number="1">
P1: Streaming response resource leak: the `stream=True` response is not closed on the non-404 path if `raise_for_status()` throws, `_parse_sse` raises (e.g., malformed JSON), or the caller abandons the generator. Wrap in `try/finally` to ensure `response.close()` is always called.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
14e2002 to
f353a54
Compare
|
@greptile plrease re-review |
Description
Standardizes the spaces between chat messages by applying
gap-12on the message container rather than rely on individual messages aligning themselves with padding.Closes https://linear.app/onyx-app/issue/ENG-3744/the-user-input-is-misaligned
How Has This Been Tested?
Reviewed the visual regression report and all changes look desired
Summary by cubic
Standardized chat message spacing by moving vertical gaps and right padding to the ChatUI container, and made HumanMessage action buttons responsive to prevent wrap-induced layout shifts. Fixes misaligned user input and keeps layouts consistent across the chat (Linear ENG-3744).
Written for commit 3a397cf. Summary will update on new commits.