feat(craft): make output/ files downloadable from Artifacts tab

[rohoswagger]

Description

Makes all output files in the outputs/ directory downloadable from the Artifacts tab in Onyx Craft. Previously, only webapp artifacts had download buttons. Now, every top-level file and folder inside outputs/ appears in the Artifacts tab with a download button:

• Files download directly via the existing artifact download endpoint
• Folders are zipped server-side via a new download-directory endpoint and downloaded as .zip files
• The outputs/web directory is excluded since it's already shown as a webapp artifact with its own download

Changes:

• Backend: Added generic download_directory method to SessionManager and GET /sessions/{id}/download-directory/{path} API endpoint
• Frontend: Added downloadArtifactFile and downloadDirectory helpers to apiServices.ts
• Frontend: Updated ArtifactsTab to fetch outputs/ directory listing and render each entry with a download button

Also addresses a tiny file upload connector bug for non-admin users.

How Has This Been Tested?

• TypeScript type check passes with zero errors
• All pre-commit hooks pass (black, ruff, prettier, etc.)
• Python syntax validation passes

Additional Options

• [Optional] Please cherry-pick this PR to the latest release version.
• [Optional] Override Linear Check

---

Summary by cubic

Make all files and folders in outputs/ downloadable from the Artifacts tab, with expandable folders to browse and download nested files or zip whole directories. Also hardens session reuse and fixes cross-user library connector mix-ups.

• New Features

  • Added GET /sessions/{session_id}/download-directory/{path} and SessionManager.download_directory to zip and download folders; arcname uses explicit prefix slicing.
  • Updated ArtifactsTab to list outputs/ (excluding outputs/web) with per-item downloads, expandable/collapsible folders, and filtered empty top-level dirs; added downloadArtifactFile and downloadDirectory helpers.

• Bug Fixes

  • list_directory returns an empty listing if the directory isn’t ready; get_or_create_empty_session verifies the workspace exists before reuse.
  • get_or_create_craft_connector filters cc_pairs by creator_id and reuses the shared connector while creating per-user cc_pairs to avoid cross-user document linkage.

^{Written for commit e0a0db5. Summary will update on new commits.}

[github-actions]

Preview Deployment

Status	Preview	Commit	Updated
✅	https://onyx-preview-a3yx36wdu-danswer.vercel.app	e0a0db5	2026-02-24 20:17:01 UTC

[cubic-dev-ai]

No issues found across 4 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

[greptile-apps]

Greptile Summary

This PR extends the Artifacts tab to make all files and folders in the outputs/ directory downloadable, not just webapp artifacts. The implementation adds a new backend endpoint for directory downloads that zips folders server-side, and updates the frontend to fetch and display all output entries with download buttons.

Key changes:

• Added GET /sessions/{session_id}/download-directory/{path} endpoint with proper error handling and security checks
• Implemented SessionManager.download_directory() method that recursively collects files and creates zip archives
• Enhanced ArtifactsTab component to fetch outputs directory listing and render files/folders with appropriate icons and download buttons
• Added downloadArtifactFile and downloadDirectory helper functions with proper URL encoding
• Frontend changes follow web standards (absolute imports, proper component usage, useSWR for data fetching)

Issues found:

• One logical issue with arcname replacement logic that needs fixing to properly handle files at the root level of the target directory

Confidence Score: 4/5

• This PR is safe to merge with one logical fix needed for the arcname handling
• The implementation is well-structured with proper security measures (path traversal protection via sandbox manager) and follows existing patterns. However, there's a logical issue in the arcname replacement logic that could cause files at the root of the target directory to have incorrect paths in the zip archive.
• backend/onyx/server/features/build/session/manager.py requires attention for the arcname logic fix

Important Files Changed

Filename	Overview
backend/onyx/server/features/build/api/sessions_api.py	Added new download_directory endpoint with proper error handling and path traversal protection
backend/onyx/server/features/build/session/manager.py	Implemented download_directory method for zipping arbitrary directories; minor issue with arcname logic for files at root level of target directory
web/src/app/craft/components/output-panel/ArtifactsTab.tsx	Enhanced UI to display all outputs directory entries with download buttons; follows web standards correctly
web/src/app/craft/services/apiServices.ts	Added download helper functions with proper URL encoding for file and directory downloads

Sequence Diagram

sequenceDiagram
    participant User
    participant ArtifactsTab
    participant API
    participant SessionManager
    participant SandboxManager

    Note over User,SandboxManager: Listing Outputs Directory
    User->>ArtifactsTab: View Artifacts Tab
    ArtifactsTab->>API: GET /sessions/{id}/files?path=outputs
    API->>SessionManager: list_directory(outputs)
    SessionManager->>SandboxManager: list_directory(outputs)
    SandboxManager-->>SessionManager: Directory entries
    SessionManager-->>API: Directory listing
    API-->>ArtifactsTab: Output files & folders
    ArtifactsTab->>User: Display files/folders with download buttons

    Note over User,SandboxManager: Downloading a File
    User->>ArtifactsTab: Click download (file)
    ArtifactsTab->>API: GET /sessions/{id}/artifacts/{path}
    API->>SessionManager: download_artifact(path)
    SessionManager->>SandboxManager: read_file(path)
    SandboxManager-->>SessionManager: File content
    SessionManager-->>API: File content + metadata
    API-->>User: Download file

    Note over User,SandboxManager: Downloading a Directory
    User->>ArtifactsTab: Click download (folder)
    ArtifactsTab->>API: GET /sessions/{id}/download-directory/{path}
    API->>SessionManager: download_directory(path)
    SessionManager->>SandboxManager: list_directory (recursive)
    loop For each file
        SessionManager->>SandboxManager: read_file(file_path)
        SandboxManager-->>SessionManager: File content
        SessionManager->>SessionManager: Add to zip
    end
    SessionManager-->>API: Zip file bytes
    API-->>User: Download .zip file

Loading

_{Last reviewed commit: 26d7461}

[greptile-apps]

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[github-actions]

🖼️ Visual Regression Report

Project	Changed	Added	Removed	Unchanged	Report
admin	38	0	0	71	View Report
exclusive	0	0	0	8	✅ No changes

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="web/src/app/craft/components/output-panel/ArtifactsTab.tsx">

<violation number="1" location="web/src/app/craft/components/output-panel/ArtifactsTab.tsx:72">
P2: Handle per-directory listing failures; otherwise a single fetch error rejects the entire Promise.all call and prevents any output entries from rendering.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}