Skip to content

chore: rename package and reorder inputs, update model defaults #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alwaysmavs merged 2 commits into from
Dec 17, 2025
Merged

chore: rename package and reorder inputs, update model defaults #55

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9951d05
chore: rename package and reorder inputs, update model defaults
alwaysmavs Dec 17, 2025
cd94cee
fix(package): normalize package name to kebab-case
alwaysmavs Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/translator/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
from oocana import LLMModelOptions
class Inputs(typing.TypedDict):
source_file: str
translated_file: str | None
language: typing.Literal["zh-Hans", "zh-Hant", "en", "fr", "de", "es", "ru", "it", "pt", "ja", "ko"]
write_mode: typing.Literal["append", "replace"]
translated_file: str | None
prompt: str | None
max_chunk_tokens: int
threads: int
Expand Down
36 changes: 18 additions & 18 deletions tasks/translator/task.oo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,6 @@ inputs_def:
- name: EPUB
extensions:
- .epub
- handle: translated_file
description: "%the-saved-path-of-the-translated-epub-file-if-not-filled-in-spec%"
json_schema:
type: string
ui:widget: save
ui:options:
excludeAll: true
filters:
- name: EPUE
extensions:
- .epub
value:
nullable: true
- group: Translate
collapsed: false
- handle: language
description: "%translation-target-language%"
json_schema:
Expand Down Expand Up @@ -59,7 +44,7 @@ inputs_def:
- Korean
value: zh-Hans
- handle: write_mode
description: '%how-is-the-translation-written-into-an-epub-file-is-it-append-to%'
description: "%how-is-the-translation-written-into-an-epub-file-is-it-append-to%"
json_schema:
enum:
- append
Expand All @@ -69,6 +54,21 @@ inputs_def:
- Append
- Replace
value: append
- group: Translate
collapsed: true
- handle: translated_file
description: '%the-saved-path-of-the-translated-epub-file-if-not-filled-in-spec%'
json_schema:
type: string
ui:widget: save
ui:options:
excludeAll: true
filters:
- name: EPUE
extensions:
- epub
value:
nullable: true
Comment on lines +57 to +71

@coderabbitai coderabbitai Bot Dec 17, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in filter name.

Line 67 contains a typo: "EPUE" should be "EPUB". This typo could cause the file filter to display incorrectly in the UI.

Apply this diff to fix the typo:

-          - name: EPUE
+          - name: EPUB
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- group: Translate
collapsed: true
- handle: translated_file
description: '%the-saved-path-of-the-translated-epub-file-if-not-filled-in-spec%'
json_schema:
type: string
ui:widget: save
ui:options:
excludeAll: true
filters:
- name: EPUE
extensions:
- epub
value:
nullable: true
- group: Translate
collapsed: true
- handle: translated_file
description: '%the-saved-path-of-the-translated-epub-file-if-not-filled-in-spec%'
json_schema:
type: string
ui:widget: save
ui:options:
excludeAll: true
filters:
- name: EPUB
extensions:
- epub
value:
nullable: true
🤖 Prompt for AI Agents 
In tasks/translator/task.oo.yaml around lines 57 to 71, the file filter name
"EPUE" is a typo and should be "EPUB"; update the filters -> - name: EPUE to -
name: EPUB so the UI file filter displays correctly (keep the extensions list
unchanged).

- handle: prompt
description: "%provide-llm-with-necessary-information-for-translating-books-for%"
json_schema:
Expand Down Expand Up @@ -110,8 +110,8 @@ inputs_def:
value:
model: deepseek-chat
temperature: 0.5
top_p: 0.5
max_tokens: 4096
top_p: 1
max_tokens: 8100
outputs_def:
- handle: translated_file
description: "%translated-epub-file-path%"
Expand Down