fix(server): count terminal event bytes - #76
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Summary by CodeRabbit
Walkthrough
Merge Risk: ⚪ Minimal · up to Terminal Run events now include their serialized UTF-8 payload size in event byte totals alongside event counts. Coverage includes all terminal statuses and repeated commits, with no remaining merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches✨ Simplify code
Comment |
Terminal Run events increased
event_countwithout updatingevent_bytes. Count their serialized UTF-8 bytes in the same transaction, using the existing event accounting convention.Regression tests cover completed, failed, canceled, and indeterminate Runs with multibyte results, and verify repeated terminal commits do not count or insert the event twice. All four cases failed before the fix and pass afterward.
Validation:
bun run format,bun run check,bun run test(1,087 tests), andbun run buildpassed.Fixes #69.