fix(ci): set Node version for server image validation - #78
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Summary by CodeRabbit
WalkthroughThe Merge Risk: ⚪ Minimal · up to The server image CI job now uses the repository’s Node version before installing dependencies, aligning it with the intended runtime configuration. No merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches✨ Simplify code
Comment |
The server_image job installed dependencies without selecting the project Node version. In CI run 33938701620, installation took 81 seconds, while the server and quality jobs that set up Node 26 took about 1–2 seconds. An unmatched Node ABI can make isolated-vm fall back to source compilation; the existing logs do not isolate its installation time.
Add the same actions/setup-node step used by the other jobs, reading .node-version before bun install. This makes the image validation runner use the project Node version and its supported native prebuilds.
Validation: bun run format and bun run check passed before the branch was created. Docker validation was not rerun locally because the Docker daemon is unavailable. The actual installation speedup remains to be verified in CI.