Skip to content

fix(ci): set Node version for server image validation - #78

Merged
l1shen merged 1 commit into
oomol-lab:mainfrom
l1shen:fix/server-image-node-version
Sep 5, 2026
Merged

fix(ci): set Node version for server image validation#78
l1shen merged 1 commit into
oomol-lab:mainfrom
l1shen:fix/server-image-node-version

Conversation

@l1shen

@l1shen l1shen commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

The server_image job installed dependencies without selecting the project Node version. In CI run 33938701620, installation took 81 seconds, while the server and quality jobs that set up Node 26 took about 1–2 seconds. An unmatched Node ABI can make isolated-vm fall back to source compilation; the existing logs do not isolate its installation time.

Add the same actions/setup-node step used by the other jobs, reading .node-version before bun install. This makes the image validation runner use the project Node version and its supported native prebuilds.

Validation: bun run format and bun run check passed before the branch was created. Docker validation was not rerun locally because the Docker daemon is unavailable. The actual installation speedup remains to be verified in CI.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: b443c74b-e23a-48c7-bc97-c0b7eeb63de6

📥 Commits

Reviewing files that changed from the base of the PR and between 50fc5f0 and 04dde1c.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.


Summary by CodeRabbit

  • Chores
    • Updated the server image verification workflow to use the project’s specified Node.js version before installing dependencies and running checks.

Walkthrough

The server_image CI job now runs actions/setup-node@v6. The step reads the Node version from .node-version before the job installs dependencies and verifies the server image.

Merge Risk: ⚪ Minimal · up to 04dde

The server image CI job now uses the repository’s Node version before installing dependencies, aligning it with the intended runtime configuration. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required <type>(<scope>): <subject> format and accurately describes the Node version update for server image validation.
Description check ✅ Passed The description explains the CI change, its purpose, validation status, and the remaining CI verification.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@l1shen
l1shen merged commit 90c3bb9 into oomol-lab:main Sep 5, 2026
8 checks passed
@l1shen
l1shen deleted the fix/server-image-node-version branch September 5, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant