fix(server): reject malformed UTF-8 webhook payloads - #89
Merged
Conversation
|
Warning Review limit reached
On-demand reviews are free for the next 14 days. After that, they cost $0.25 per reviewed file. Or wait 30 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
xuedingjie
force-pushed
the
fix/webhook-utf8
branch
from
September 6, 2026 16:20
1666ff2 to
fc300a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
readWebhookPayloaddecoded request bytes with the defaultTextDecoder, which replaces malformed UTF-8 sequences withU+FFFD. A malformed JSON request could therefore be accepted after its payload was silently rewritten, and a Run would be created with data different from the bytes sent by the caller.Fix
Decode Webhook bodies with a fatal UTF-8 decoder and map decoding failures to the existing
400invalid-request response. Add a regression test that sends an invalid UTF-8 sequence and verifies that no Run is created.This matches the strict decoder already used by the Integration callback path and the JSON UTF-8 requirement in RFC 8259 section 8.1.
Verification
npx --yes bun@1.4.0 x vitest run --config vitest.config.ts test/webhook.test.tsnpx --yes bun@1.4.0 x oxfmt --check apps/server/node/http.ts apps/server/test/webhook.test.tsnpx --yes bun@1.4.0 x oxlint --deny-warnings apps/server/node/http.ts apps/server/test/webhook.test.tsnpx --yes bun@1.4.0 x tsc --noEmit -p apps/server/tsconfig.json