fix(server): reject malformed UTF-8 Connector responses - #91
Merged
Conversation
|
Warning Review limit reached
On-demand reviews are free for the next 14 days. After that, they cost $0.25 per reviewed file. Or wait 13 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ConnectorClientdecoded upstream response bytes withBuffer.toString('utf8'). Malformed UTF-8 was replaced withU+FFFDbefore JSON parsing, so a response such as a Team/Provider name could be accepted with data different from the bytes returned by the Connector service.Fix
Decode Connector JSON responses with a fatal UTF-8 decoder. The existing
connector.unavailableerror mapping remains unchanged. Add a regression test using an invalid UTF-8 sequence in a Teams response.This matches the strict decoding used by Integration callbacks and follows the JSON UTF-8 requirement in RFC 8259 section 8.1.
Verification
npx --yes bun@1.4.0 x vitest run --config vitest.config.ts test/connectorClient.test.ts -t "malformed UTF-8"npx --yes bun@1.4.0 x oxfmt --check apps/server/node/connector.ts apps/server/test/connectorClient.test.tsnpx --yes bun@1.4.0 x oxlint --deny-warnings apps/server/node/connector.ts apps/server/test/connectorClient.test.tsnpx --yes bun@1.4.0 x tsc --noEmit -p apps/server/tsconfig.json